Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding codecov token and fixing dev container #1968

Closed
wants to merge 1 commit into from
Closed

Adding codecov token and fixing dev container #1968

wants to merge 1 commit into from

Conversation

jake-skipper
Copy link
Contributor

Summary

This PR does the following:

  • Adds the Codecov token to the pipeline, which will hopefully fix the repeated Codecov upload errors due to Github API rate limiting.
  • Slightly adjusts the dev container to get get poetry working again for users who leverage the dev container locally.

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@github-actions github-actions bot added github_actions Update to GitHub Actions maintenance General repo or CI/CD upkeep labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #1968 (ae7008d) into master (b97bb9b) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1968   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         247      247           
  Lines       15667    15667           
=======================================
  Hits        14128    14128           
  Misses       1539     1539

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722a4a1...ae7008d. Read the comment docs.

@jake-skipper
Copy link
Contributor Author

Closing to add codecov conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jake-skipper jake-skipper

Labels
github_actions Update to GitHub Actions maintenance General repo or CI/CD upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jake-skipper